Skip to content

fix: Fixing redis store error when passing empty keys array #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 19, 2022
Merged

fix: Fixing redis store error when passing empty keys array #15

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ee7074
checking keys length before calling cache.del(keys)
jkyberneees Jun 19, 2022
2f979a5
updating dependencies
jkyberneees Jun 19, 2022
bd0e808
adding automated testing
jkyberneees Jun 19, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
checking keys length before calling cache.del(keys)
  • Loading branch information
@jkyberneees
jkyberneees committed Jun 19, 2022
commit 5ee707480bc1f9657dc70e04ff1f527fab9dd32e
2 changes: 1 addition & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ const middleware = (opts) => async (req, res, next) => {
return acc
}, [])
// delete keys on all cache tiers
patterns.forEach(pattern => opts.stores.forEach(store => getKeys(store, pattern).then(keys => mcache.del(keys))))
patterns.forEach(pattern => opts.stores.forEach(store => getKeys(store, pattern).then(keys => keys.length > 0 ? mcache.del(keys) : null)))
} else if (payload.headers[X_CACHE_TIMEOUT] || payload.headers[CACHE_CONTROL]) {
// extract cache ttl
let ttl = 0
Expand Down