Write/create/truncate prototxt when saving to fix #341 #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| Cool, thanks Evan! |
jeffdonahue added a commit that referenced this pull request May 14, 2014
Write/create/truncate prototxt when saving to fix #341
This was referenced May 15, 2014
Merged
mitmul pushed a commit to mitmul/caffe that referenced this pull request Sep 30, 2014
Write/create/truncate prototxt when saving to fix BVLC#341
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Create the output file if it doesn't exist or overwrite it if it exists with content when saving a prototxt and set permissions to owner all and group + other read.
One could overwrite a prototxt this way, but such is the peril of saving files.
This will cherry-picked to master or a new release will be made soon enough to fix the problem there.