Skip to content

Conversation

@dargilco
Copy link
Member

@dargilco dargilco commented Dec 3, 2025

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables test recording for the files tests (both sync and async versions) by removing the skip decorator that was preventing recording and configuring the tests to use HTTPX transport recording. The changes update the test recordings reference in assets.json to include the newly recorded HTTP interactions.

Key Changes

  • Removed @pytest.mark.skipif decorator that was skipping tests during recording
  • Updated import to use RecordedTransport instead of is_live_and_not_recording
  • Configured @recorded_by_proxy decorators with RecordedTransport.HTTPX parameter to record OpenAI client HTTP calls
  • Updated assets.json tag to reference new test recordings

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
sdk/ai/azure-ai-projects/tests/files/test_files.py Enabled test recording by removing skip decorator, updated imports, and configured HTTPX transport recording for synchronous file operations test
sdk/ai/azure-ai-projects/tests/files/test_files_async.py Enabled test recording by removing skip decorator, updated imports, and configured HTTPX transport recording for asynchronous file operations test
sdk/ai/azure-ai-projects/assets.json Updated Tag to reference new test recordings that include the files tests
@dargilco dargilco changed the title Add tests recordings for files tests Add tests recordings for "files" operations tests Dec 4, 2025
@dargilco dargilco merged commit 94afd69 into main Dec 4, 2025
20 checks passed
@dargilco dargilco deleted the dargilco/add-tests-recordings-for-files-tests branch December 4, 2025 00:50
rads-1996 pushed a commit to rads-1996/azure-sdk-for-python that referenced this pull request Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants