[ServiceBus] Replacing scaling logs to WebJobs extension methods #53926
+30 −23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
alrod requested review from a team, ArthurMa1978, EldertGrootenboer, jorgerangel-msft, jsquire and skarri-microsoft as code owners 
Copilot finished reviewing on behalf of alrod November 14, 2025 00:19
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces custom scaling logs in the Service Bus WebJobs extension with standardized WebJobs extension methods (LogFunctionScaleVote and LogFunctionScaleError). The changes update the WebJobs package version to 3.0.42-dev which presumably includes these new logging extension methods.
Key changes:
- Renamed
functionIdparameters tofunctionNamefor consistency with the new logging methods - Replaced
LogInformationandLogWarningcalls with structured logging extension methodsLogFunctionScaleVoteandLogFunctionScaleError - Updated WebJobs package dependency from version 3.0.41 to 3.0.42-dev
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ServiceBusTargetScaler.cs | Renamed _functionId to _functionName; replaced LogInformation with LogFunctionScaleVote for scale vote logging |
| ServiceBusScaleMonitor.cs | Renamed _functionId to _functionName; passed function name to ServiceBusMetricsProvider |
| ServiceBusMetricsProvider.cs | Added _functionName field and constructor parameter; replaced LogWarning calls with LogFunctionScaleError |
| Packages.Data.props | Updated Microsoft.Azure.WebJobs packages from 3.0.41 to 3.0.42-dev |
| NuGet.Config | Added local NuGet package source |
Comments suppressed due to low confidence (1)
sdk/servicebus/Microsoft.Azure.WebJobs.Extensions.ServiceBus/src/Listeners/ServiceBusMetricsProvider.cs:28
- Corrected spelling of 'Subcription' to 'Subscription' in '_mainSubcriptionName'.
private readonly string _mainSubcriptionName; 
mathewc reviewed Nov 14, 2025
...bus/Microsoft.Azure.WebJobs.Extensions.ServiceBus/src/Listeners/ServiceBusMetricsProvider.cs Show resolved Hide resolved
mathewc reviewed Nov 14, 2025
| } | ||
| catch (UnauthorizedAccessException ex) | ||
| { | ||
| if (TimeToLogWarning()) | ||
| { | ||
| _logger.LogWarning(ex, $"Connection string does not have 'Manage Claim' for {entityName} '{_entityPath}'. Unable to determine active message count."); | ||
| string message = $"Connection string does not have 'Manage Claim' for {entityName} '{_entityPath}'. Unable to determine active message count."; |
Member
There was a problem hiding this comment.
nit: can you avoid declaring message as before and just inline this in the log call? Same comment throughout. Wondering why you're not doing this consistently - e.g. on line 109 its inlined.
mathewc reviewed Nov 14, 2025
...bus/Microsoft.Azure.WebJobs.Extensions.ServiceBus/src/Listeners/ServiceBusMetricsProvider.cs Outdated Show resolved Hide resolved
mathewc reviewed Nov 14, 2025
| @@ -17,7 +17,7 @@ namespace Microsoft.Azure.WebJobs.ServiceBus.Listeners | |||
| { | |||
| internal class ServiceBusScaleMonitor : IScaleMonitor<ServiceBusTriggerMetrics> | |||
| { | |||
| private readonly string _functionId; | |||
| private readonly string _functionName; | |||
Member
There was a problem hiding this comment.
Why this change? Looks like its functionId for all the other monitors
Member Author
There was a problem hiding this comment.
replaced to functionId for consultancy
mathewc reviewed Nov 14, 2025
...bus/Microsoft.Azure.WebJobs.Extensions.ServiceBus/src/Listeners/ServiceBusMetricsProvider.cs Show resolved Hide resolved
alrod force-pushed the alrod/replace-logs-sb branch from eb27187 to 8430784 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.