Use simpler delegate when constructing AzureEventSourceListener #46202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
pharring requested review from TimothyMothra, cijothomas, jsquire, rajkumar-rangaraj and reyang as code owners 
github-actions bot added Community Contribution 
| Thank you for your contribution @pharring! We will review the pull request and get back to you soon. |
Collaborator
| API change check API changes are not detected in this pull request. |
rajkumar-rangaraj approved these changes Sep 24, 2024
jsquire approved these changes Sep 26, 2024
Member
jsquire left a comment
jsquire left a comment There was a problem hiding this comment.
Can we please add a changelog comment for the extensions just generically noting that we've improved efficiency of the forwarder?
Member
| Thanks, @pharring! We'll see about getting this into October's releases. |
Member
| /check-enforcer override |
pharring deleted the dev/pharring/ConsumeNewAzureEventSourceConstructor branch Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Following the completion of #45191 and the publishing of an Azure.Core version with that change, this PR makes use of the new constructor in the Extensions Monitor.OpenTelemetry projects.