Merge NPM Port Rules Properly #456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jaer-tsun force-pushed the fixPortRules branch 2 times, most recently from 7185933 to 7e1aa97 Compare jaer-tsun force-pushed the fixPortRules branch from 7e1aa97 to 2ed39c7 Compare jaer-tsun changed the title 
matmerr approved these changes Dec 17, 2019
ashutoshishere04 pushed a commit to ashutoshishere04/azure-container-networking that referenced this pull request Jan 23, 2020
* Fix NPM port rules * Add port entry logic for ipblock, namespace, and pod selector; Fix tests. * removing unnecessary hops between chains
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Merge NPM Port Rules Properly.
Combine port rules with namespace selector, pod selector, and/or ipblock rules.