Join vnet as a part of NC publish #451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## master #451 +/- ## ========================================== - Coverage 53.32% 53.24% -0.08% ========================================== Files 28 28 Lines 4032 4032 ========================================== - Hits 2150 2147 -3 - Misses 1610 1612 +2 - Partials 272 273 +1
Continue to review full report at Codecov.
|
jaer-tsun reviewed Dec 3, 2019
ashutoshishere04 pushed a commit to ashutoshishere04/azure-container-networking that referenced this pull request Jan 23, 2020
Join vnet before publishing NC. This is required as nmagent may be restarted which causes the NC publishing to fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Join vnet before publishing NC. This is required as nmagent may be
restarted which causes the NC publishing to fail.
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: