-
Couldn't load subscription status.
- Fork 259
fix: replace AKS LTS versioning with commonly reached k8s patch version #4094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| /azp run |
| Azure Pipelines successfully started running 2 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes an issue with AKS LTS versioning where the Kubernetes patch version format changed from A.BC.DE to A.BC.1DE, breaking automated downloads of upstream k8s-e2e test suites. The fix detects LTS versions (patch version >= 100) and normalizes them to a commonly available patch version (.12) from upstream Kubernetes.
Key changes:
- Added logic to detect AKS LTS versions by checking if the patch version is >= 100
- Implemented normalization to use patch version
.12for LTS versions to match available upstream test artifacts
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| .pipelines/cni/k8s-e2e/k8s-e2e.jobs.yaml | Added LTS version detection and normalization logic before downloading k8s test artifacts |
| .pipelines/cni/k8s-e2e/k8s-e2e-job-template.yaml | Added identical LTS version detection and normalization logic |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
31abd9f to 46c99a1 Compare | /azp run Azure Container Networking PR |
| Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Reason for Change:
AKS LTS versioning now sets its kubernetes patch version to
A.BC.1DEinstead of the expectedA.BC.DEThis broke the automation for upstream k8s-e2e test suite downloads as we leveraged the cluster versioning for the test we were going to run.
Issue Fixed:
Requirements:
Notes:
Needs to be forwardported