Skip to content

Conversation

@jpayne3506
Copy link
Contributor

Reason for Change:

AKS LTS versioning now sets its kubernetes patch version to A.BC.1DE instead of the expected A.BC.DE

This broke the automation for upstream k8s-e2e test suite downloads as we leveraged the cluster versioning for the test we were going to run.

Issue Fixed:

Requirements:

Notes:
Needs to be forwardported

@jpayne3506 jpayne3506 requested a review from a team as a code owner October 21, 2025 21:42
@jpayne3506 jpayne3506 added the fix Fixes something. label Oct 21, 2025
@jpayne3506 jpayne3506 added ci Infra or tooling. release/latest Change affects latest release train release/1.5 Change affects v1.5 release train release/1.6 Change affects 1.6 release train labels Oct 21, 2025
@jpayne3506
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue with AKS LTS versioning where the Kubernetes patch version format changed from A.BC.DE to A.BC.1DE, breaking automated downloads of upstream k8s-e2e test suites. The fix detects LTS versions (patch version >= 100) and normalizes them to a commonly available patch version (.12) from upstream Kubernetes.

Key changes:

  • Added logic to detect AKS LTS versions by checking if the patch version is >= 100
  • Implemented normalization to use patch version .12 for LTS versions to match available upstream test artifacts

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
.pipelines/cni/k8s-e2e/k8s-e2e.jobs.yaml Added LTS version detection and normalization logic before downloading k8s test artifacts
.pipelines/cni/k8s-e2e/k8s-e2e-job-template.yaml Added identical LTS version detection and normalization logic

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

rayaisaiah
rayaisaiah previously approved these changes Oct 21, 2025
@jpayne3506
Copy link
Contributor Author

/azp run Azure Container Networking PR

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).
@jpayne3506 jpayne3506 requested a review from Copilot October 21, 2025 21:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jpayne3506 jpayne3506 enabled auto-merge October 21, 2025 21:49
@jpayne3506 jpayne3506 added this pull request to the merge queue Oct 21, 2025
@jpayne3506 jpayne3506 added the needs-backport Change needs to be backported to previous release trains label Oct 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 22, 2025
@paulyufan2 paulyufan2 added this pull request to the merge queue Oct 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 22, 2025
@paulyufan2 paulyufan2 added this pull request to the merge queue Oct 22, 2025
@rayaisaiah rayaisaiah removed this pull request from the merge queue due to a manual request Oct 22, 2025
@rayaisaiah rayaisaiah added this pull request to the merge queue Oct 22, 2025
Merged via the queue into release/v1.6 with commit f62f910 Oct 22, 2025
10 of 15 checks passed
@rayaisaiah rayaisaiah deleted the jpayne3506/k8sVer-fix branch October 22, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Infra or tooling. fix Fixes something. needs-backport Change needs to be backported to previous release trains release/latest Change affects latest release train release/1.5 Change affects v1.5 release train release/1.6 Change affects 1.6 release train

2 participants