Add v2 zap logger to cns apis #4003
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I see we now have a zap logger v2 for cns
In #4002. I am getting:
SA1019: logger.Printf is deprecated: The global logger is deprecated. Migrate to zap using the cns/logger/v2 package and pass the logger instead. (staticcheck)So this PR is to introduce the zap v2 logger into CNS APIs, by plumbing it through the CNS service config
Thoughts?
This would make
azure-container-networking/cns/restserver/api.go
Line 48 in f636b50
Into something like this:
I understand we already have a way to make
logger.Printf()to point to a v2 zap logger underneath:azure-container-networking/cns/service/main.go
Lines 650 to 653 in f636b50
But this is more about when adding new APIs, and to avoid the linting errors