fix: add code generation to run-unit-tests.stages #3985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds missing code generation steps to the signed binary release pipeline. The change ensures that BPF code generation is performed during unit tests for the release pipeline, bringing it in sync with the existing PR pipeline configuration.
- Adds
make bpf-libandgo generate ./...commands to generate required BPF code - Synchronizes the signed binary release pipeline with the PR pipeline unit test configuration
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| /azp run Azure Container Networking PR |
| Azure Pipelines successfully started running 1 pipeline(s). |
jpayne3506 previously approved these changes Sep 2, 2025
github-merge-queue bot removed this pull request from the merge queue due to failed status checks 
santhoshmprabhu dismissed stale reviews from jpayne3506 and QxBytes via a883535 | /azp run Azure Container Networking PR |
| Azure Pipelines successfully started running 1 pipeline(s). |
| /azp run Azure Container Networking PR |
| Azure Pipelines successfully started running 1 pipeline(s). |
santhoshmprabhu force-pushed the sanprabhu/update-unit-test-stages branch from 7c6ae83 to 58b57e4 Compare jpayne3506 approved these changes Sep 3, 2025
| /azp run Azure Container Networking PR |
QxBytes approved these changes Sep 3, 2025
| Azure Pipelines successfully started running 1 pipeline(s). |
github-merge-queue bot removed this pull request from the merge queue due to failed status checks 
sivakami-projects pushed a commit that referenced this pull request Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Reason for Change:
We introduced bpf code as part of the iptables block binary, that relies on code generation. We updated run-unit-tests.yaml, which is used by the UT runs on the PR pipeline, to have the extra code generation steps. But the signed binary release uses run-unit-tests.stages.yaml, which wasn't updated. This PR adds the code generation to that file as well.
Issue Fixed:
Requirements:
Notes: