ci: only check for code coverage at merge, not release #3791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR aims to control code coverage publication based on the PR’s target branch and surface that branch in the pipeline logs.
- Introduces a commented-out condition to skip coverage reporting for non-master PRs.
- Adds an echo of the PR target branch name to pipeline output for debugging.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .pipelines/templates/run-unit-tests.yaml | Added a commented-out branch check above coverage task |
| .pipelines/pipeline.yaml | Echoes the PR’s targetBranchName in the environment stage |
Comments suppressed due to low confidence (2)
.pipelines/templates/run-unit-tests.yaml:98
- Remove or clarify this commented-out condition. If you intend to gate coverage reports by branch, uncomment, test, and document the logic, or delete the placeholder to avoid confusion.
# - ${{ if not(contains(variables['System.PullRequest.targetBranchName'], 'master')) }}: .pipelines/pipeline.yaml:56
- [nitpick] If this echo is only for debugging, add a comment explaining its use or remove it before merging to keep pipeline logs focused.
echo $(System.PullRequest.targetBranchName) 
jpayne3506 force-pushed the jpayne3506/code-block branch 2 times, most recently from 04d585c to 7ffa102 Compare jpayne3506 force-pushed the jpayne3506/code-block branch from 7ffa102 to 0d11a2f Compare 
QxBytes approved these changes Jul 10, 2025
jpayne3506 added fix 
| in other words, i only care about code coverage before a change has merged. if it's merged and we're releasing, coverage is not relevant. |
rbtr approved these changes Jul 10, 2025
| /azp run Azure Container Networking PR |
| Azure Pipelines successfully started running 1 pipeline(s). |
rbtr changed the title 4 tasks
rbtr pushed a commit that referenced this pull request Jul 10, 2025
ci: only check for code coverage
NihaNallappagari pushed a commit to NihaNallappagari/azure-container-networking that referenced this pull request Sep 4, 2025
ci: only check for code coverage
sivakami-projects pushed a commit that referenced this pull request Oct 23, 2025
ci: only check for code coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Reason for Change:
We only need to run code coverage on PR(s) merging to master as
release/*branches are frozen to feature development and would only see a fix if it has already been merged to master as well.Issue Fixed:
Requirements:
Notes: