Skip to content

Conversation

@jpayne3506
Copy link
Contributor

Reason for Change:

Issue Fixed:

Requirements:

Notes:

@jpayne3506 jpayne3506 self-assigned this Jul 3, 2025
Copilot AI review requested due to automatic review settings July 3, 2025 19:52
@jpayne3506 jpayne3506 requested a review from a team as a code owner July 3, 2025 19:52
@jpayne3506 jpayne3506 added ci Infra or tooling. cilium Related to Cilium. labels Jul 3, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Centralize and streamline Cilium CLI installation and connectivity testing by moving repeated scripts into reusable templates.

  • Introduce a new cilium-connectivity-tests.yaml template for running connectivity tests with retry-on-failure logic.
  • Replace inline Cilium CLI install and connectivity test steps in the LSG CNI integration pipeline with references to cilium-cli.yaml and cilium-connectivity-tests.yaml.
  • Comment out legacy script blocks to reduce duplication.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.pipelines/templates/cilium-connectivity-tests.yaml Add reusable connectivity tests step with debug fallback
.pipelines/cni/lsg/lsg-cni-intergration-template.yaml Swap inline CLI install and tests with template references
Comments suppressed due to low confidence (4)

.pipelines/templates/cilium-connectivity-tests.yaml:5

  • The original inline step included retryCountOnTaskFailure: 6 to automatically retry flaky connectivity tests. Consider adding the same retry logic to this template to maintain resiliency.
 - script: | 

.pipelines/templates/cilium-connectivity-tests.yaml:6

  • The previous inline step cleaned up the load-test namespace before running tests. Add kubectl delete ns load-test prior to invoking the connectivity test to ensure a clean test environment.
 if ! cilium connectivity test --connect-timeout 4s --request-timeout 30s --test ${{ parameters.skipTests }} --force-deploy 

.pipelines/cni/lsg/lsg-cni-intergration-template.yaml:190

  • [nitpick] Consider removing the large commented-out Cilium CLI install block (lines 190–207) entirely, since it’s replaced by the cilium-cli.yaml template. This will reduce noise and improve readability.
 # - script: | 

.pipelines/templates/cilium-connectivity-tests.yaml:2

  • [nitpick] Add a comment describing the skipTests parameter and its negation syntax (e.g., !test-name) so users understand that this config excludes specific tests.
 skipTests: '!pod-to-pod-encryption,!node-to-node-encryption,!check-log-errors,!no-unexpected-packet-drops,!to-fqdns' 
@jpayne3506 jpayne3506 force-pushed the jpayne3506/lsg-cli-fix branch from 91f1356 to a4afdb2 Compare July 7, 2025 16:59
camrynl
camrynl previously approved these changes Jul 7, 2025
Copy link
Contributor

@camrynl camrynl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ - after pipelines complete

@jpayne3506
Copy link
Contributor Author

/azp run Azure Container Networking PR

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).
Copy link
Contributor

@QxBytes QxBytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great for cleaning up that connectivity test redundancy

@jpayne3506 jpayne3506 added this pull request to the merge queue Jul 11, 2025
Merged via the queue into master with commit 7d56d36 Jul 11, 2025
14 of 15 checks passed
@jpayne3506 jpayne3506 deleted the jpayne3506/lsg-cli-fix branch July 11, 2025 22:43
NihaNallappagari pushed a commit to NihaNallappagari/azure-container-networking that referenced this pull request Sep 4, 2025
* ci: update lsg connectivity/cli * ci: update Connectivity test usages to template call * fix: replace ciliumNamespace var
sivakami-projects pushed a commit that referenced this pull request Oct 23, 2025
* ci: update lsg connectivity/cli * ci: update Connectivity test usages to template call * fix: replace ciliumNamespace var
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Infra or tooling. cilium Related to Cilium.

4 participants