-
Couldn't load subscription status.
- Fork 259
ci: cleanup Cilium cli and connectivity test usage #3772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Centralize and streamline Cilium CLI installation and connectivity testing by moving repeated scripts into reusable templates.
- Introduce a new
cilium-connectivity-tests.yamltemplate for running connectivity tests with retry-on-failure logic. - Replace inline Cilium CLI install and connectivity test steps in the LSG CNI integration pipeline with references to
cilium-cli.yamlandcilium-connectivity-tests.yaml. - Comment out legacy script blocks to reduce duplication.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .pipelines/templates/cilium-connectivity-tests.yaml | Add reusable connectivity tests step with debug fallback |
| .pipelines/cni/lsg/lsg-cni-intergration-template.yaml | Swap inline CLI install and tests with template references |
Comments suppressed due to low confidence (4)
.pipelines/templates/cilium-connectivity-tests.yaml:5
- The original inline step included
retryCountOnTaskFailure: 6to automatically retry flaky connectivity tests. Consider adding the same retry logic to this template to maintain resiliency.
- script: | .pipelines/templates/cilium-connectivity-tests.yaml:6
- The previous inline step cleaned up the
load-testnamespace before running tests. Addkubectl delete ns load-testprior to invoking the connectivity test to ensure a clean test environment.
if ! cilium connectivity test --connect-timeout 4s --request-timeout 30s --test ${{ parameters.skipTests }} --force-deploy .pipelines/cni/lsg/lsg-cni-intergration-template.yaml:190
- [nitpick] Consider removing the large commented-out Cilium CLI install block (lines 190–207) entirely, since it’s replaced by the
cilium-cli.yamltemplate. This will reduce noise and improve readability.
# - script: | .pipelines/templates/cilium-connectivity-tests.yaml:2
- [nitpick] Add a comment describing the
skipTestsparameter and its negation syntax (e.g.,!test-name) so users understand that this config excludes specific tests.
skipTests: '!pod-to-pod-encryption,!node-to-node-encryption,!check-log-errors,!no-unexpected-packet-drops,!to-fqdns' 91f1356 to a4afdb2 Compare There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ - after pipelines complete
| /azp run Azure Container Networking PR |
| Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is great for cleaning up that connectivity test redundancy
* ci: update lsg connectivity/cli * ci: update Connectivity test usages to template call * fix: replace ciliumNamespace var
* ci: update lsg connectivity/cli * ci: update Connectivity test usages to template call * fix: replace ciliumNamespace var
Reason for Change:
Issue Fixed:
Requirements:
Notes: