Revert "Add HomeAZ to NodeInfoStatus" #3758
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This reverts commit 8fd1503.
There was a problem hiding this comment.
Pull Request Overview
Reverts the addition of the HomeAZ property from NodeInfo CRD and status types.
- Removed
homeAZschema entry from the CRD manifest - Removed
HomeAZfield from theDeviceInfostruct in Go
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crd/multitenancy/manifests/multitenancy.acn.azure.com_nodeinfo.yaml | Remove homeAZ property definition from CRD spec |
| crd/multitenancy/api/v1alpha1/nodeinfo.go | Remove HomeAZ field and validation tags from DeviceInfo |
rbtr approved these changes Jun 26, 2025
| Recommend closing in favor of #3762 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Reverts #3738
New Home AZ property should be in spec not status