Skip to content

Conversation

@QxBytes
Copy link
Contributor

@QxBytes QxBytes commented Jun 24, 2025

Reason for Change:

When creating tags for ip masq merger, the ACN_VERSION variable in the makefile should not include the tags with "azure-ip-masq-merger"
Before:
tar (child): acncli-linux-amd64-azure-ip-masq-merger/v0.0.1.tgz: Cannot open: No such file or directory
After:
tar -czvf acncli-linux-amd64-v1.6.26-13-gcc221ca94.tgz acn

Issue Fixed:

Requirements:

Notes:

@QxBytes QxBytes self-assigned this Jun 24, 2025
@QxBytes QxBytes added ci Infra or tooling. cilium Related to Cilium. labels Jun 24, 2025
@QxBytes QxBytes marked this pull request as ready for review June 24, 2025 00:05
Copilot AI review requested due to automatic review settings June 24, 2025 00:05
@QxBytes QxBytes requested a review from a team as a code owner June 24, 2025 00:05
@QxBytes QxBytes requested a review from chandanAggarwal June 24, 2025 00:05
@QxBytes
Copy link
Contributor Author

QxBytes commented Jun 24, 2025

/azp run Azure Container Networking PR

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Makefile’s versioning logic to omit tags from the azure-ip-masq-merger project when generating the ACN_VERSION.

  • Added azure-ip-masq-merger* to the exclusion list in git describe for ACN_VERSION
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).
@QxBytes QxBytes enabled auto-merge June 24, 2025 00:06
@QxBytes QxBytes added this pull request to the merge queue Jun 24, 2025
Merged via the queue into master with commit 0b8ba8a Jun 24, 2025
23 of 25 checks passed
@QxBytes QxBytes deleted the alew/exclude-azure-ip-masq-merger-in-version branch June 24, 2025 05:06
sivakami-projects pushed a commit that referenced this pull request Oct 23, 2025
) exclude azure-ip-masq-merger* tags when describing acn version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Infra or tooling. cilium Related to Cilium.

3 participants