Skip to content

Conversation

@jpayne3506
Copy link
Contributor

Reason for Change:

Maintenace for multiple release train versions are slipping. This PR is the first of multiple to leverage variable groups to allow E2E pipelines to use latest managed version where applicable.

Issue Fixed:

Requirements:

Notes:

@jpayne3506 jpayne3506 requested review from camrynl and vipul-21 May 15, 2025 18:18
@jpayne3506 jpayne3506 self-assigned this May 15, 2025
Copilot AI review requested due to automatic review settings May 15, 2025 18:18
@jpayne3506 jpayne3506 requested a review from a team as a code owner May 15, 2025 18:18
@jpayne3506 jpayne3506 added the ci Infra or tooling. label May 15, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces automated version management for AKS cluster creation pipelines by leveraging variable groups and adds support for a Long Term Support (LTS) flag.

  • Added LTS_ARGS in hack/aks/Makefile to conditionally apply LTS options to az aks create commands
  • Extended the cluster creation template to accept an LTS parameter
  • Configured pipeline jobs to pass the LTS flag based on Kubernetes version

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
hack/aks/Makefile Define LTS_ARGS and inject into cluster creation targets
.pipelines/templates/create-cluster-steps.yaml Add LTS parameter usage in the cluster creation steps template
.pipelines/cni/ado-automation/var-pipeline.yaml Set LTS flag in pipeline job parameters for specific versions
Comments suppressed due to low confidence (1)

.pipelines/templates/create-cluster-steps.yaml:1

  • The template references a parameter 'LTS' in the steps but it isn't defined under parameters:. Add a definition like LTS: false (or an appropriate default) to ensure the flag is recognized.
parameters: 
@jpayne3506 jpayne3506 force-pushed the jpayne3506/ado-var branch 6 times, most recently from d6dfe62 to b4a383f Compare May 15, 2025 22:41
@jpayne3506 jpayne3506 force-pushed the jpayne3506/ado-var branch from b4a383f to 3bcbabf Compare May 19, 2025 17:13
@Azure Azure deleted a comment from azure-pipelines bot May 19, 2025
@jpayne3506
Copy link
Contributor Author

/azp run Azure Container Networking PR

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).
@jpayne3506 jpayne3506 enabled auto-merge May 22, 2025 17:49
@jpayne3506 jpayne3506 added this pull request to the merge queue May 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 22, 2025
@jpayne3506 jpayne3506 added this pull request to the merge queue May 23, 2025
Merged via the queue into master with commit 585ef7a May 23, 2025
15 of 16 checks passed
@jpayne3506 jpayne3506 deleted the jpayne3506/ado-var branch May 23, 2025 20:08
sivakami-projects pushed a commit that referenced this pull request Oct 23, 2025
* test: view variable group * ci: all k8s version * chore: cleanup debug output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Infra or tooling.

4 participants