ci: Update ACN Pipeline for Compliance #3597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the ACN pipelines for compliance by standardizing pool configurations and enhancing Dockerfile reference management. Key changes include:
- Updated pool definitions in multiple pipeline templates to use "type: linux" and "isCustom: true".
- Removal of outdated steps in the aks-swift E2E step template.
- Introduction of new utility scripts for renaming Dockerfile references along with enhancements to build and manifest generation steps.
Reviewed Changes
Copilot reviewed 48 out of 57 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| .pipelines/singletenancy/aks/e2e-job-template.yaml | Added custom pool settings for improved job configuration. |
| .pipelines/singletenancy/aks-swift/e2e-step-template.yaml | Removed legacy environment setup steps. |
| .pipelines/singletenancy/aks-swift/e2e-job-template.yaml | Standardized pool setups and added checkout steps. |
| .pipelines/cni/k8s-e2e/k8s-e2e-job-template.yaml | Updated pool configuration and inserted a checkout step. |
| .pipelines/build/utils/rename-dockerfile-references.steps.yaml | Introduced new utility steps for Dockerfile renaming. |
| .pipelines/build/publish-manifest.steps.yaml | Added new steps to publish manifest data. |
| .pipelines/build/ob-prepare.steps.yaml | Integrated new Dockerfile renaming templates and cleanup. |
| .pipelines/build/manifests.jobs.yaml | Added jobs to generate and publish image manifests. |
| .pipelines/build/image.steps.yaml | Refined image build and output steps with updated arguments. |
| .pipelines/build/generate-manifest.steps.yaml | Created steps to populate image manifest data using jq. |
| .pipelines/build/binary.steps.yaml | Added steps to build binaries with pre-requisites and artifact preparation. |
Files not reviewed (9)
- .pipelines/OneBranch.NonOfficial.CrossPlat.yaml: Language not supported
- .pipelines/OneBranch.Official.CrossPlat.yaml: Language not supported
- .pipelines/cni/k8s-e2e/k8s-e2e.jobs.yaml: Language not supported
- .pipelines/containers/container-template.steps.yaml: Language not supported
- .pipelines/containers/manifest-template.steps.yaml: Language not supported
- .pipelines/multitenancy/swiftv2-e2e.jobs.yaml: Language not supported
- .pipelines/singletenancy/aks-swift/aks-swift-e2e.jobs.yaml: Language not supported
- .pipelines/singletenancy/aks/aks-e2e.jobs.yaml: Language not supported
- .pipelines/singletenancy/aks/aks-e2e.steps.yaml: Language not supported
Comments suppressed due to low confidence (1)
.pipelines/build/utils/rename-dockerfile-references.steps.yaml:7
- The word 'fascilitates' appears to be misspelled. Consider replacing it with 'facilitates'.
# 'Dockerfile'. This fascilitates the creation of this template in order to 
sheylatrudo force-pushed the smtrudo/acn-onebranch branch from 0a8eb80 to 69f9083 Compare 
| There was an error handling pipeline event eda55476-d32a-481c-b755-e415d7bfc484. |
sheylatrudo force-pushed the smtrudo/acn-onebranch branch from f8144a1 to 7a34418 Compare 
sheylatrudo force-pushed the smtrudo/acn-onebranch branch from 7a34418 to 8a5c974 Compare Using new files to prevent existing pipelines from failing.
jpayne3506 requested changes May 2, 2025
.pipelines/singletenancy/dualstack-overlay/dualstackoverlay-e2e.steps.yaml Outdated Show resolved Hide resolved
test/integration/manifests/cilium/v1.14/cilium-agent/templates/daemonset-dualstack.yaml Outdated Show resolved Hide resolved
test/integration/manifests/cilium/v1.14/cilium-agent/templates/daemonset-dualstack.yaml Outdated Show resolved Hide resolved
| /azp run Azure Container Networking PR |
| Azure Pipelines successfully started running 1 pipeline(s). |
| /azp run Azure Container Networking PR |
| Azure Pipelines successfully started running 1 pipeline(s). |
jpayne3506 requested changes May 7, 2025
Co-authored-by: John Payne <89417863+jpayne3506@users.noreply.github.com> Signed-off-by: sheylatrudo <sheyla.trudo@gmail.com>
| /azp run Azure Container Networking PR |
| Azure Pipelines successfully started running 1 pipeline(s). |
jpayne3506 approved these changes May 7, 2025
| /azp run CNI Release Test |
| Azure Pipelines successfully started running 1 pipeline(s). |
| Above is non-blocking |
sheylatrudo changed the title 
rbtr approved these changes May 7, 2025
rohitams approved these changes May 7, 2025
github-merge-queue bot removed this pull request from the merge queue due to failed status checks github-merge-queue bot removed this pull request from the merge queue due to failed status checks sivakami-projects pushed a commit that referenced this pull request Oct 23, 2025
* Edit Pipeline Trigger * ci: E2E work * Update Variables to Generated Values * fixup! Update Variables to Generated Values * Use New Pipeline Files Using new files to prevent existing pipelines from failing. * fixup! Use New Pipeline Files * fixup! Use New Pipeline Files * fixup! Use New Pipeline Files * fixup! Use New Pipeline Files * fixup! Use New Pipeline Files * fixup! Use New Pipeline Files * Update Dockerfiles * Update Dockerfiles * fixup! Update Dockerfiles * fixup! Use New Pipeline Files * fixup! Use New Pipeline Files * fixup! Use New Pipeline Files * Update .pipelines/build/utils/rename-dockerfile-references.steps.yaml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: sheylatrudo <sheyla.trudo@gmail.com> * Update .pipelines/build/utils/rename-dockerfile-references.steps.yaml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: sheylatrudo <sheyla.trudo@gmail.com> * Update .pipelines/singletenancy/dualstack-overlay/dualstackoverlay-e2e.steps.yaml Co-authored-by: John Payne <89417863+jpayne3506@users.noreply.github.com> Signed-off-by: sheylatrudo <sheyla.trudo@gmail.com> * Address PR Comments * fixup! Use New Pipeline Files * fixup! Use New Pipeline Files * fixup! Address PR Comments * fixup! Address PR Comments * fixup! Address PR Comments * Remove Dockerfile Changes for Testing * fixup! Remove Dockerfile Changes for Testing * Update .pipelines/singletenancy/cilium-dualstack-overlay/cilium-dualstackoverlay-e2e.steps.yaml Signed-off-by: John Payne <89417863+jpayne3506@users.noreply.github.com> * Update .pipelines/singletenancy/cilium-nodesubnet/cilium-nodesubnet-e2e.steps.yaml Signed-off-by: John Payne <89417863+jpayne3506@users.noreply.github.com> * Update .pipelines/singletenancy/cilium-overlay-withhubble/cilium-overlay-e2e.steps.yaml Signed-off-by: John Payne <89417863+jpayne3506@users.noreply.github.com> * Update .pipelines/singletenancy/cilium-overlay/cilium-overlay-e2e.steps.yaml Signed-off-by: John Payne <89417863+jpayne3506@users.noreply.github.com> * fixup! Address PR Comments * fixup! Address PR Comments * fixup! Address PR Comments * Add IPV6_IMAGE_REPO_PATH to Tests * Update .pipelines/cni/cilium/cilium-scale-test.yaml Co-authored-by: John Payne <89417863+jpayne3506@users.noreply.github.com> Signed-off-by: sheylatrudo <sheyla.trudo@gmail.com> --------- Signed-off-by: sheylatrudo <sheyla.trudo@gmail.com> Signed-off-by: John Payne <89417863+jpayne3506@users.noreply.github.com> Co-authored-by: jpayne3506 <payne.3506@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: John Payne <89417863+jpayne3506@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Reason for Change:
The ACN PR pipeline is currently unable to build signed images due to organizational policies. This PR duplicates the current pipeline for the creation of tooling that enables builds on machines compliant with Microsoft policies.
Merging this PR will not activate this tooling but readies the repository for a smooth switchover.
Issue Fixed:
Requirements:
Notes: