-
Couldn't load subscription status.
- Fork 259
fix: [Linux] [NPM] handle #2977 for netpols without cidrs #2990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Signed-off-by: Hunter Gregory <42728408+huntergregory@users.noreply.github.com>
huntergregory commented Sep 5, 2024
07d29cd to 3cac503 Compare Signed-off-by: Hunter Gregory <42728408+huntergregory@users.noreply.github.com>
3cac503 to 5730821 Compare Signed-off-by: Hunter Gregory <42728408+huntergregory@users.noreply.github.com>
| /azp run Azure Container Networking PR |
| /azp run NPM Conformance Tests |
| /azp run NPM Scale Test |
| Azure Pipelines successfully started running 1 pipeline(s). |
2 similar comments
| Azure Pipelines successfully started running 1 pipeline(s). |
| Azure Pipelines successfully started running 1 pipeline(s). |
rayaisaiah approved these changes Sep 10, 2024
huntergregory added a commit that referenced this pull request Sep 11, 2024
…2990) * fix: [Linux] [NPM] handle #2977 for netpols without cidrs Signed-off-by: Hunter Gregory <42728408+huntergregory@users.noreply.github.com> * fix: lock and no need to track policy key Signed-off-by: Hunter Gregory <42728408+huntergregory@users.noreply.github.com> * style: remove dead code Signed-off-by: Hunter Gregory <42728408+huntergregory@users.noreply.github.com> --------- Signed-off-by: Hunter Gregory <42728408+huntergregory@users.noreply.github.com>
4 tasks
github-merge-queue bot pushed a commit that referenced this pull request Sep 12, 2024
…3006) [backport] fix: [Linux] [NPM] handle #2977 for netpols without cidrs (#2990) * fix: [Linux] [NPM] handle #2977 for netpols without cidrs * fix: lock and no need to track policy key * style: remove dead code --------- Signed-off-by: Hunter Gregory <42728408+huntergregory@users.noreply.github.com>
sivakami-projects pushed a commit that referenced this pull request Oct 23, 2025
* fix: [Linux] [NPM] handle #2977 for netpols without cidrs Signed-off-by: Hunter Gregory <42728408+huntergregory@users.noreply.github.com> * fix: lock and no need to track policy key Signed-off-by: Hunter Gregory <42728408+huntergregory@users.noreply.github.com> * style: remove dead code Signed-off-by: Hunter Gregory <42728408+huntergregory@users.noreply.github.com> --------- Signed-off-by: Hunter Gregory <42728408+huntergregory@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Reason for Change:
#2977 actually could happen for any NetPol. Redoing #2978 to handle all NetPols. This fix forces the data plane to successfully apply IPSets before starting to add a policy if the previous RemovePolicy call failed to apply ipsets. This prevents the chance of NPM removing a policy, flushing all policy IPSets, but failing to delete policy IPSets, then NPM adding the policy back thinking that the policy IPSets are in the kernel with all members (when there are actually no members in the IPSets due to the flush).
Issue Fixed:
Fix #2977 completely
Requirements:
Notes:
Logs for the Fix
Editing Policy
Removing then Readding Policy