Skip to content

Conversation

@henrymbuguakiarie
Copy link
Contributor

Purpose

I've added a named snippet section within the code for out-of-repo snippet references.

Does this introduce a breaking change?

[ ] Yes [X] No 

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix [ ] Feature [ ] Code style update (formatting, local variables) [ ] Refactoring (no functional changes, no api changes) [X] Documentation content changes [ ] Other... Please describe: 

How to Test

  • Get the code
git clone [repo-address] cd [repo-name] git checkout [branch-name] npm install 
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

Hello @ckittel @mmacy I've added a named snippet section within the code for out-of-repo snippet references. Please review
@henrymbuguakiarie
Copy link
Contributor Author

Hello @ckittel @mmacy Please review

Copy link
Member

@ckittel ckittel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ckittel ckittel merged commit e137bec into Azure-Samples:main Jan 20, 2022
Copy link
Contributor

@mmacy mmacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@henrymbuguakiarie Missed the merge, but please take note of this comment.

FYI for @ckittel for future reviews and @Dickson-Mwendia for future out-of-repo-code snippet (OORCS) integration.

)

# First check for an existing token in the cache and/or refresh if needed
# <ms_docref_get_graph_token>
Copy link
Contributor

@mmacy mmacy Jan 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@henrymbuguakiarie Please include descriptive comments like this in the named snippets.

# First check for an existing token in the cache and/or refresh if needed

Cc: @ckittel @Dickson-Mwendia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants