Initial import of "Device Code flow in Python console app" #5
Conversation
ckittel left a comment
ckittel left a comment There was a problem hiding this comment.
Nice, here's my eng review feedback. Nice work.
Co-authored-by: Chad Kittel <chad.kittel@gmail.com>
ckittel left a comment
ckittel left a comment There was a problem hiding this comment.
This is in addition to the prior review, with only has one open comment.
Updated with formatting from 'black'
Co-authored-by: Chad Kittel <chad.kittel@gmail.com>
"web APP" -> "console"
Co-authored-by: Chad Kittel <chad.kittel@gmail.com>
ckittel left a comment
ckittel left a comment There was a problem hiding this comment.
Looks great from a C&L Engineering review perspective. Thanks!
msal-device-flow-python/README.md Outdated
| | ||
| ## About the code | ||
| | ||
| This Python application will request a user to authenticate via the web browser. Upon successful authentication a request to the Graph API will be made and the response will be displayed. |
There was a problem hiding this comment.
This currently describes what the application does rather than the code that enables it.
The intent of this section is to provide a more technical (yet still high-level) overview of how the code itself works. Things like which auth library (or libraries) it uses, the primary library types it uses, how the redirects and auth flow goes... that sort of thing.
There was a problem hiding this comment.
Thanks - I'll work on an update
Co-authored-by: Marsh Macy <mmacy@users.noreply.github.com>
Updated "About the code"
3 participants
This is for #DOCS-CODE-032.
Simple web app written in Python 3 that demonstrates how to authenticate a user to call Graph via the Device Code flow.