Skip to content

Conversation

@ckittel
Copy link
Member

@ckittel ckittel commented Dec 10, 2021

This is for #DOCS-CODE-019.

Simple web app written in Python Flask that shows protected routes and also how one of the routes can use access tokens that the user granted the web app permission to retrieve to access Microsoft Graph on the user's behalf.

@ckittel ckittel self-assigned this Dec 10, 2021
@ckittel ckittel requested a review from mmacy December 10, 2021 15:47
Copy link

@ferantivero ferantivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicely done @ckittel just a few comments here and there. Nothing that block us but just the discuss around.

@ckittel ckittel marked this pull request as ready for review December 10, 2021 16:32
Copy link
Contributor

@mmacy mmacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some requested changes. I'll work on the intro paragraph again tomorrow or later this week. I had a sweet version written up that I lost on Friday. :(

ckittel and others added 2 commits December 14, 2021 12:41
Co-authored-by: Marsh Macy <mmacy@users.noreply.github.com>
@ckittel ckittel requested a review from mmacy December 14, 2021 19:55
Copy link
Contributor

@mmacy mmacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple nits, no blockers. Thanks @ckittel.

@ckittel
Copy link
Member Author

ckittel commented Dec 16, 2021

Thanks @mmacy and @ferantivero, merging now.

@ckittel ckittel merged commit 3355acb into main Dec 16, 2021
@ckittel ckittel deleted the web-app branch December 16, 2021 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants