Skip to content
This repository was archived by the owner on Feb 21, 2023. It is now read-only.

Fix life cycle warnings #159

Open
ChicaoDev wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix life cycle warnings #159

ChicaoDev wants to merge 2 commits into from

Conversation

@ChicaoDev
Copy link

@ChicaoDev ChicaoDev commented Oct 30, 2019

No description provided.

@netlify
Copy link

netlify bot commented Oct 30, 2019

Deploy preview for availity-reactstrap-validation ready!

Built with commit 05764f8

https://deploy-preview-159--availity-reactstrap-validation.netlify.com
@TheSharpieOne
Copy link
Collaborator

TheSharpieOne commented Dec 10, 2019

This change requires a change to the minimum react and react-dom versions since the UNSAFE_ methods are new(er).
If you check out the preview, you'll see that nothing works.
@robmcguinness robmcguinness added the breaking change Changes that would require major version bump to library label Dec 10, 2019
@mrsarm
Copy link

mrsarm commented Apr 30, 2020

I cannot wait until this is published, for a project that it's in bootstrapping phase in a professional environment it's hard to explain to your architect leader or just your team leader why you chose to use a library that triggers warnings on each view of the application, it makes the library to look outdated and wrong, so for everybody with the same issue than me, here is a fork that solves the issue: https://www.npmjs.com/package/availity-reactstrap-validation-safe
@mrsarm mrsarm mentioned this pull request Apr 30, 2020
Open
@mistysmilesalot
Copy link

mistysmilesalot commented Nov 11, 2020

@Murzbul @sublimedatasys @yafimsva Is this ever going to make it in to the package?
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

breaking change Changes that would require major version bump to library

8 participants

@ChicaoDev @TheSharpieOne @mrsarm @mistysmilesalot @Murzbul @sublimedatasys @yafimsva @robmcguinness