Skip to content

Fix: handle RetinaFace landmarks correctly (nose, mouth_left and mouth_right) #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: handle RetinaFace landmarks correctly (nose, mouth_left and mouth_right) #24

wants to merge 1 commit into from

Conversation

AdaiasMagdiel
Copy link

This PR fixes #23.

  • Issue: Unknown named parameter $nose when using Detector::RETINAFACE
  • Cause: RetinaFace returns landmarks (nose, mouth_left, mouth_right, etc.) not properly mapped.
  • Fix: Normalize landmark keys before constructing the object.

Tested with:

  • Detector::RETINAFACE
  • FaceRecognitionModel::ARCFACE

Result: represent() now returns embeddings successfully without crashing.
@AdaiasMagdiel
Fix: handle RetinaFace landmarks correctly (nose, mouth_left and mout…
b6b52a9 
…h_right) This PR fixes [Astrotomic#23](Astrotomic#23). - Issue: `Unknown named parameter $nose` when using `Detector::RETINAFACE` - Cause: RetinaFace returns landmarks (`nose`, `mouth_left`, `mouth_right`, etc.) not properly mapped. - Fix: Normalize landmark keys before constructing the object. Tested with: - `Detector::RETINAFACE` - `FaceRecognitionModel::ARCFACE` Result: `represent()` now returns embeddings successfully without crashing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@AdaiasMagdiel