[Implement] Buffer.readInt8 #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
- Adds a custom bootstrapper - Adds example - Adds types file - Adds fs namespace - Adds buffer namespace - Adds env types
| @dcodeIO this looks good to me. Did we miss anything? |
dcodeIO reviewed Jul 20, 2019
assembly/buffer/index.ts Outdated
| } | ||
| | ||
| readInt8(offset: i32) : i8 { | ||
| if(u32(offset) >= this.dataLength) throw new RangeError(E_INDEXOUTOFRANGE); |
There was a problem hiding this comment.
In stdlib, which is also non-portable, this is usually written as <u32>offset. Might make sense to adopt the stdlib notation in the node library as well for consistency.
| Looking good, just a minor nit :) |
jtenner approved these changes Jul 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Kudos to @jtenner for assistance with this.