[Cleanup] readInt8's offset defaults to 0 #10
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
* Add initial instructions to README * more concrete * address comments * link preliminary api docs * more general
…ssemblyScript#4) * [Feature] Implement Buffer.alloc and Buffer.allocUnsafe, add tests * [Tests] Add Actual and Expected message * [Tests] Add todos to implement when Try/Catch is supported * [Cleanup] import Uint8Array manually to avoid @ts-ignore
| @dcodeIO looks like he's still learning how to use git :). Think we can accept this instead? |
| @RedDwarfian you can close this yourself when you're ready. |
| All good. Would usually recommend adding these function all at once to reduce reviewing/merging overhead, but if you're ok with it then I'm as well. Great to see a new contributor in the first place :) |
| The goal was to help him get comfortable with git and writing assemblyscript functions. Lots of practice :) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Made
readInt8offsetdefault to0, and modified casting to use stdlib's<u32>offsetsyntax.