Skip to content

Conversation

HerrCai0907
Copy link
Member

No description provided.

@HerrCai0907 HerrCai0907 changed the title chore: refactor unary postfix code emitter to reduce nested tostack (#2949) chore: refactor builtin type resolve to builtins.ts Sep 25, 2025
@HerrCai0907 HerrCai0907 changed the title chore: refactor builtin type resolve to builtins.ts chore: refactor builtin type resolving to builtins.ts Sep 25, 2025
@CountBleck
Copy link
Member

What's the rationale behind the change? Do you intend to add other builtin types to your fork?

@HerrCai0907
Copy link
Member Author

I am researching how to add ValueType in AS and taking a look of the builtin type implement.
Then I found we should move the builtin type resolving to builtins.ts like other builtins.

@CountBleck
Copy link
Member

I think moving it there is a good idea too

Copy link
Member

@CountBleck CountBleck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HerrCai0907 HerrCai0907 merged commit 7322bfc into AssemblyScript:main Sep 27, 2025
14 checks passed
@HerrCai0907 HerrCai0907 deleted the refactor/builtin-type branch September 27, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants