Skip to content

fix: internalPath in parseFile is not same with Source #1836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2021
Merged

fix: internalPath in parseFile is not same with Source #1836

merged 1 commit into from
Apr 29, 2021

Conversation

yjhmelody
Copy link
Contributor

@yjhmelody yjhmelody commented Apr 29, 2021 •
edited
Loading

in Souce:

var internalPath = mangleInternalPath(normalizedPath);

in parseFile:

var normalizedPath = normalizePath(path); var internalPath = mangleInternalPath(path);

I got two path string:

  • ./examples/foo
  • examples/foo
@MaxGraey
Copy link
Member

@willemneal could you check this as well?
@willemneal
Copy link
Contributor

Yeah looks good to me! Good catch!
@MaxGraey MaxGraey merged commit 802a233 into AssemblyScript:master Apr 29, 2021
@MaxGraey
Copy link
Member

Thanks!
@yjhmelody yjhmelody deleted the fix-parseFile branch April 30, 2021 02:24
@yjhmelody yjhmelody mentioned this pull request Apr 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@yjhmelody @MaxGraey @willemneal