Skip to content

Conversation

surma
Copy link
Contributor

@surma surma commented Apr 18, 2021

Fixes #1813

  • I've read the contributing guidelines
surma and others added 2 commits April 18, 2021 16:28
Co-authored-by: Max Graey <maxgraey@gmail.com>
Co-authored-by: Max Graey <maxgraey@gmail.com>
@surma
Copy link
Contributor Author

surma commented Apr 18, 2021

Cheers @MaxGraey

surma and others added 2 commits April 18, 2021 19:06
Co-authored-by: Max Graey <maxgraey@gmail.com>
Copy link
Member

@MaxGraey MaxGraey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you confirm does it work?

@surma
Copy link
Contributor Author

surma commented Apr 19, 2021

@MaxGraey I wanted to, but I am honestly not sure how to do that as the SDK hard-codes CDN URLs. It’s something that I think should be fixed, but probably in a separate PR.

@MaxGraey MaxGraey merged commit eca391b into AssemblyScript:master Apr 19, 2021
@MaxGraey
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants