Skip to content

feat: implemented getters / setters and various string fns on Date #1768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 14, 2021
Merged

feat: implemented getters / setters and various string fns on Date #1768

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3ede539
feat: added UTC getter / setter methods
ColinEberhardt Mar 29, 2021
7fa6d4f
feat: implemented toISOString and fromString
ColinEberhardt Mar 29, 2021
0b647dd
feat: removed the need use JS for the Date.UTC function
ColinEberhardt Mar 29, 2021
b7ac6bd
chore: linting fixes and added name to NOTICE
ColinEberhardt Mar 29, 2021
0ad464b
refactor: modified ymdFromEpochDays to remove allocations
ColinEberhardt Mar 29, 2021
5f236a4
refactor: simplified 'days in month' logic
ColinEberhardt Mar 29, 2021
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: linting fixes and added name to NOTICE
  • Loading branch information
@ColinEberhardt
ColinEberhardt committed Apr 13, 2021
commit b7ac6bd1a28fdd9bba3e6c3967c366b93945b62a
1 change: 1 addition & 0 deletions NOTICE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ under the licensing terms detailed in LICENSE:
* ookangzheng <git-ed@runbox.no>
* yjhmelody <yjh465402634@gmail.com>
* bnbarak <bn.barak@gmail.com>
* Colin Eberhardt <colin.eberhardt@gmail.com>

Portions of this software are derived from third-party works licensed under
the following terms:
Expand Down
6 changes: 3 additions & 3 deletions std/assembly/date.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ export class Date {

static fromString(dateTimeString: string): Date {
let hour: i32 = 0,
minute: i32 = 0,
second: i32 = 0,
millisecond: i32 = 0;
minute: i32 = 0,
second: i32 = 0,
millisecond: i32 = 0;
let dateString: string;

if (dateTimeString.includes("T")) {
Expand Down
268 changes: 135 additions & 133 deletions tests/compiler/std/date.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,185 +1,187 @@
// Date UTC /////////////////////////////////////////////////////////////////////////////////
{
assert(Date.UTC(1970, 0, 1) == 0);
assert(Date.UTC(1970, 0, 1, 0, 0, 0, 0) == 0);
assert(Date.UTC(1970, 0, 1) == 0);
assert(Date.UTC(1970, 0, 1, 0, 0, 0, 0) == 0);

let creationTime = Date.UTC(2018, 10, 10, 11, 0, 0, 1);
assert(creationTime == 1541847600001);
let creationTime = Date.UTC(2018, 10, 10, 11, 0, 0, 1);
assert(creationTime == 1541847600001);
}

// Date get / set Time /////////////////////////////////////////////////////////////////////////////////

{
let creationTime = 1541847600001;
let date = new Date(creationTime);
assert(date.getTime() == creationTime);
date.setTime(creationTime + 1);
assert(date.getTime() == creationTime + 1);
let creationTime = 1541847600001;
let date = new Date(creationTime);
assert(date.getTime() == creationTime);
date.setTime(creationTime + 1);
assert(date.getTime() == creationTime + 1);
}


// Date getters /////////////////////////////////////////////////////////////////////////////////

{
// from +189512-12-14T22:09:43.706Z"
let date = new Date(5918283958183706);
assert(date.getUTCFullYear() == 189512);
assert(date.getUTCMonth() == 11);
assert(date.getUTCDate() == 14);
assert(date.getUTCHours() == 22);
assert(date.getUTCMinutes() == 9);
assert(date.getUTCSeconds() == 43);
assert(date.getUTCMilliseconds() == 706);
// from +189512-12-14T22:09:43.706Z"
let date = new Date(5918283958183706);
assert(date.getUTCFullYear() == 189512);
assert(date.getUTCMonth() == 11);
assert(date.getUTCDate() == 14);
assert(date.getUTCHours() == 22);
assert(date.getUTCMinutes() == 9);
assert(date.getUTCSeconds() == 43);
assert(date.getUTCMilliseconds() == 706);
}

{
// from 1973-12-04T01:03:11.274Z"
let date = new Date(123814991274);
assert(date.getUTCFullYear() == 1973);
assert(date.getUTCMonth() == 11);
assert(date.getUTCDate() == 4);
assert(date.getUTCHours() == 1);
assert(date.getUTCMinutes() == 3);
assert(date.getUTCSeconds() == 11);
assert(date.getUTCMilliseconds() == 274);
// from 1973-12-04T01:03:11.274Z"
let date = new Date(123814991274);
assert(date.getUTCFullYear() == 1973);
assert(date.getUTCMonth() == 11);
assert(date.getUTCDate() == 4);
assert(date.getUTCHours() == 1);
assert(date.getUTCMinutes() == 3);
assert(date.getUTCSeconds() == 11);
assert(date.getUTCMilliseconds() == 274);
}

// Date#setUTCMilliseconds /////////////////////////////////////////////////////////////////////////////////
{
let date = new Date(399464523963984);
assert(date.getUTCMilliseconds() == 984);
date.setUTCMilliseconds(12);
assert(date.getUTCMilliseconds() == 12);
date.setUTCMilliseconds(568);
assert(date.getUTCMilliseconds() == 568);
// test boundaries
date.setUTCMilliseconds(0);
date.setUTCMilliseconds(999);
let date = new Date(399464523963984);
assert(date.getUTCMilliseconds() == 984);
date.setUTCMilliseconds(12);
assert(date.getUTCMilliseconds() == 12);
date.setUTCMilliseconds(568);
assert(date.getUTCMilliseconds() == 568);
// test boundaries
date.setUTCMilliseconds(0);
date.setUTCMilliseconds(999);
}

// Date#setUTCSeconds /////////////////////////////////////////////////////////////////////////////////
{
let date = new Date(372027318331986);
assert(date.getUTCSeconds() == 31);
date.setUTCSeconds(12);
assert(date.getUTCSeconds() == 12);
date.setUTCSeconds(50);
assert(date.getUTCSeconds() == 50);
// test boundaries
date.setUTCSeconds(0);
date.setUTCSeconds(59);
let date = new Date(372027318331986);
assert(date.getUTCSeconds() == 31);
date.setUTCSeconds(12);
assert(date.getUTCSeconds() == 12);
date.setUTCSeconds(50);
assert(date.getUTCSeconds() == 50);
// test boundaries
date.setUTCSeconds(0);
date.setUTCSeconds(59);
}

// Date#setUTCMinutes /////////////////////////////////////////////////////////////////////////////////
{
let date = new Date(372027318331986);
assert(date.getUTCMinutes() == 45);
date.setUTCMinutes(12);
assert(date.getUTCMinutes() == 12);
date.setUTCMinutes(50);
assert(date.getUTCMinutes() == 50);
// test boundaries
date.setUTCMinutes(0);
date.setUTCMinutes(59);
let date = new Date(372027318331986);
assert(date.getUTCMinutes() == 45);
date.setUTCMinutes(12);
assert(date.getUTCMinutes() == 12);
date.setUTCMinutes(50);
assert(date.getUTCMinutes() == 50);
// test boundaries
date.setUTCMinutes(0);
date.setUTCMinutes(59);
}

// Date#setUTCHours /////////////////////////////////////////////////////////////////////////////////
{
let date = new Date(372027318331986);
assert(date.getUTCHours() == 17);
date.setUTCHours(12);
assert(date.getUTCHours() == 12);
date.setUTCHours(2);
assert(date.getUTCHours() == 2);
// test boundaries
date.setUTCHours(0);
date.setUTCHours(23);
let date = new Date(372027318331986);
assert(date.getUTCHours() == 17);
date.setUTCHours(12);
assert(date.getUTCHours() == 12);
date.setUTCHours(2);
assert(date.getUTCHours() == 2);
// test boundaries
date.setUTCHours(0);
date.setUTCHours(23);
}

// Date#setUTCDate /////////////////////////////////////////////////////////////////////////////////
{
let date = new Date(123814991274);
assert(date.getUTCFullYear() == 1973);
assert(date.getUTCMonth() == 11);

// test a few values
date.setUTCDate(12);
assert(date.getUTCDate() == 12);
date.setUTCDate(2);
assert(date.getUTCDate() == 2);

// test boundaries
// nov has 30 days
date.setUTCDate(1);
date.setUTCDate(30);

// jan has 31 days
date.setUTCMonth(1);
date.setUTCDate(1);
date.setUTCDate(31);

// feb on leap year
date.setUTCFullYear(2024);
date.setUTCMonth(2);
date.setUTCDate(1);
date.setUTCDate(29);
let date = new Date(123814991274);
assert(date.getUTCFullYear() == 1973);
assert(date.getUTCMonth() == 11);

// test a few values
date.setUTCDate(12);
assert(date.getUTCDate() == 12);
date.setUTCDate(2);
assert(date.getUTCDate() == 2);

// test boundaries
// nov has 30 days
date.setUTCDate(1);
date.setUTCDate(30);

// jan has 31 days
date.setUTCMonth(1);
date.setUTCDate(1);
date.setUTCDate(31);

// feb on leap year
date.setUTCFullYear(2024);
date.setUTCMonth(2);
date.setUTCDate(1);
date.setUTCDate(29);
}

// Date#setUTCMonth /////////////////////////////////////////////////////////////////////////////////
{
let date = new Date(7899943856218720);
assert(date.getUTCMonth() == 3);
date.setUTCMonth(10);
assert(date.getUTCMonth() == 10);
date.setUTCMonth(2);
assert(date.getUTCMonth() == 2);
// test boundaries
date.setUTCMonth(1);
date.setUTCMonth(12);
let date = new Date(7899943856218720);
assert(date.getUTCMonth() == 3);
date.setUTCMonth(10);
assert(date.getUTCMonth() == 10);
date.setUTCMonth(2);
assert(date.getUTCMonth() == 2);
// test boundaries
date.setUTCMonth(1);
date.setUTCMonth(12);
}

// Date#setUTCFullYear /////////////////////////////////////////////////////////////////////////////////
{
let date = new Date(7941202527925698);
assert(date.getUTCFullYear() == 253616);
date.setUTCFullYear(1976);
assert(date.getUTCFullYear() == 1976);
date.setUTCFullYear(20212);
assert(date.getUTCFullYear() == 20212);
let date = new Date(7941202527925698);
assert(date.getUTCFullYear() == 253616);
date.setUTCFullYear(1976);
assert(date.getUTCFullYear() == 1976);
date.setUTCFullYear(20212);
assert(date.getUTCFullYear() == 20212);
}

// Date#toString /////////////////////////////////////////////////////////////////////////////////
{
let date = new Date(1231231231020);
assert(date.toISOString() == "2009-01-06T08:40:31.020Z");
date = new Date(1231231231456);
assert(date.toISOString() == "2009-01-06T08:40:31.456Z");
date = new Date(322331231231020)
assert(date.toISOString() == "+012184-04-08T13:07:11.020Z");
let date = new Date(1231231231020);
assert(date.toISOString() == "2009-01-06T08:40:31.020Z");
date = new Date(1231231231456);
assert(date.toISOString() == "2009-01-06T08:40:31.456Z");
date = new Date(322331231231020);
assert(date.toISOString() == "+012184-04-08T13:07:11.020Z");
}

// Date#fromString /////////////////////////////////////////////////////////////////////////////////
{
// supports year / month / day
let date = Date.fromString("1976-02-02");
assert(date.getTime() == 192067200000);
date = Date.fromString("1976-2-2");
assert(date.getTime() == 192067200000);
date = Date.fromString("2345-11-04");
assert(date.getTime() == 11860387200000);

// supports two digit years
assert(Date.fromString("1976-04-02").getTime() == Date.fromString("76-04-02").getTime());

// supports year / month / day / hour / minute / second
date = Date.fromString("1976-02-02T12:34:56");
assert(date.getTime() == 192112496000);

// supports milliseconds
date = Date.fromString("1976-02-02T12:34:56.456");
assert(date.getTime() == 192112496456);

// supports 'Z' suffix
date = Date.fromString("1976-02-02T12:34:56.456Z");
assert(date.getTime() == 192112496456);
}
// supports year / month / day
let date = Date.fromString("1976-02-02");
assert(date.getTime() == 192067200000);
date = Date.fromString("1976-2-2");
assert(date.getTime() == 192067200000);
date = Date.fromString("2345-11-04");
assert(date.getTime() == 11860387200000);

// supports two digit years
assert(
Date.fromString("1976-04-02").getTime() ==
Date.fromString("76-04-02").getTime()
);

// supports year / month / day / hour / minute / second
date = Date.fromString("1976-02-02T12:34:56");
assert(date.getTime() == 192112496000);

// supports milliseconds
date = Date.fromString("1976-02-02T12:34:56.456");
assert(date.getTime() == 192112496456);

// supports 'Z' suffix
date = Date.fromString("1976-02-02T12:34:56.456Z");
assert(date.getTime() == 192112496456);
}