Skip to content

Conversation

@AriPerkkio
Copy link
Owner

No description provided.

@AriPerkkio
Copy link
Owner Author

AriPerkkio commented Mar 30, 2021

@github-actions eslint-remote-tester compare

{ rulesUnderTesting: [ 'react/jsx-max-depth' ], eslintrc: { rules: { 'react/jsx-max-depth': 'error' } }, }

Run 5

Repository owner deleted a comment from github-actions bot Mar 31, 2021
Repository owner deleted a comment from github-actions bot Mar 31, 2021
@github-actions
Copy link

Comparison results

Compared branches:

  • Base: AriPerkkio/eslint-plugin-react/master
  • PR: AriPerkkio/eslint-plugin-react/test/regression

Detected 4 new ESLint reports and 1 reports to be not present.

Click to expand

Added:

Rule: react/jsx-max-depth

  • Message: Expected the depth of nested jsx elements to be <= 2, but found 4.
  • Path: Devorein/Qocean/client/src/components/Modal/WarnModal.jsx
  • Link
 20 | <Fade in={isOpen}> 21 | <DialogContent> > 22 | <Icon icon="cancel" onClick={onClose} popoverText="Close Modal" /> |	^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 23 | <div className="modal_content">{children}</div> 24 | <div className={clxs('modal_buttons', classes.buttons)}> 25 | <Button className="modal_buttons--cancel" onClick={onCancel}>

Rule: react/jsx-max-depth

  • Message: Expected the depth of nested jsx elements to be <= 2, but found 4.
  • Path: Devorein/Qocean/client/src/components/Modal/WarnModal.jsx
  • Link
 21 | <DialogContent> 22 | <Icon icon="cancel" onClick={onClose} popoverText="Close Modal" /> > 23 | <div className="modal_content">{children}</div> |	^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 24 | <div className={clxs('modal_buttons', classes.buttons)}> 25 | <Button className="modal_buttons--cancel" onClick={onCancel}> 26 | {cancelMsg ? cancelMsg : 'Cancel'}

Rule: react/jsx-max-depth

  • Message: Expected the depth of nested jsx elements to be <= 2, but found 5.
  • Path: Devorein/Qocean/client/src/components/Modal/WarnModal.jsx
  • Link
 23 | <div className="modal_content">{children}</div> 24 | <div className={clxs('modal_buttons', classes.buttons)}> > 25 | <Button className="modal_buttons--cancel" onClick={onCancel}> |	^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > 26 | {cancelMsg ? cancelMsg : 'Cancel'} | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > 27 | </Button> | ^^^^^^^^^^^^^^^^^^ 28 | <Button className="modal_buttons--accept" onClick={onAccept}> 29 | {acceptMsg ? acceptMsg : 'Accept'} 30 | </Button>

Rule: react/jsx-max-depth

  • Message: Expected the depth of nested jsx elements to be <= 2, but found 5.
  • Path: Devorein/Qocean/client/src/components/Modal/WarnModal.jsx
  • Link
 26 | {cancelMsg ? cancelMsg : 'Cancel'} 27 | </Button> > 28 | <Button className="modal_buttons--accept" onClick={onAccept}> |	^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > 29 | {acceptMsg ? acceptMsg : 'Accept'} | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > 30 | </Button> | ^^^^^^^^^^^^^^^^^^ 31 | </div> 32 | </DialogContent> 33 | </Fade>

Removed:

Rule: jsx-max-depth

  • Message: Maximum call stack size exceeded Occurred while linting <text>:22
  • Path: Devorein/Qocean/client/src/components/Modal/WarnModal.jsx
  • Link
 20 | <Fade in={isOpen}> 21 | <DialogContent> > 22 | <Icon icon="cancel" onClick={onClose} popoverText="Close Modal" /> 23 | <div className="modal_content">{children}</div> 24 | <div className={clxs('modal_buttons', classes.buttons)}> 25 | <Button className="modal_buttons--cancel" onClick={onCancel}>
RangeError: Maximum call stack size exceeded Occurred while linting <text>:22 at Object.getVariable (/home/runner/work/eslint-plugin-react/eslint-plugin-react/lib/util/variable.js:24:21) at findJSXElementOrFragment (/home/runner/work/eslint-plugin-react/eslint-plugin-react/lib/rules/jsx-max-depth.js:104:37) at find (/home/runner/work/eslint-plugin-react/eslint-plugin-react/lib/rules/jsx-max-depth.js:97:18) at findJSXElementOrFragment (/home/runner/work/eslint-plugin-react/eslint-plugin-react/lib/rules/jsx-max-depth.js:105:49) at find (/home/runner/work/eslint-plugin-react/eslint-plugin-react/lib/rules/jsx-max-depth.js:97:18) at findJSXElementOrFragment (/home/runner/work/eslint-plugin-react/eslint-plugin-react/lib/rules/jsx-max-depth.js:105:49) at find (/home/runner/work/eslint-plugin-react/eslint-plugin-react/lib/rules/jsx-max-depth.js:97:18) at findJSXElementOrFragment (/home/runner/work/eslint-plugin-react/eslint-plugin-react/lib/rules/jsx-max-depth.js:105:49) at find (/home/runner/work/eslint-plugin-react/eslint-plugin-react/lib/rules/jsx-max-depth.js:97:18) at findJSXElementOrFragment (/home/runner/work/eslint-plugin-react/eslint-plugin-react/lib/rules/jsx-max-depth.js:105:49) 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants