Skip to content

Report compile errors in shared library #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jul 1, 2022
Merged

Report compile errors in shared library #327

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
e09a4d2
Run "TestSomething" on Windows as well as Ubuntu.
jgfoster Jul 1, 2022
f50b07b
Update CHANGELOG.md
jgfoster Jul 1, 2022
ad34cba
Properly report compile error in shared library.
jgfoster Jul 1, 2022
2b01256
See if fixing code causes test to pass.
jgfoster Jul 1, 2022
7dbd96c
Try fixes for errors
jgfoster Jul 1, 2022
012f5bb
WIP: use `eval` and `next unless`
jgfoster Jul 1, 2022
71a18b3
WIP: blank line; another attempt to capture status
jgfoster Jul 1, 2022
18c43a5
WIP: another attempt at a status code
jgfoster Jul 1, 2022
d7b76a8
Move test script into separate file.
jgfoster Jul 1, 2022
da3be8f
path to test script
jgfoster Jul 1, 2022
07a9d1d
See if we can force failure.
jgfoster Jul 1, 2022
c42d2f8
If there is no error reported, it should be an error!
jgfoster Jul 1, 2022
80fda42
Will this report a failure?
jgfoster Jul 1, 2022
43f8d05
This should do it!
jgfoster Jul 1, 2022
fb65bcd
Merge branch 'master' into shared_library
jgfoster Jul 1, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
WIP: use eval and next unless
  • Loading branch information
@jgfoster
jgfoster committed Jul 1, 2022
commit 012f5bb99a1a37d7ed067f5656e2ca312fb20ab6
3 changes: 1 addition & 2 deletions .github/workflows/linux.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,7 @@ jobs:
cd SampleProjects/SharedLibrary
bundle install
bundle exec ensure_arduino_installation.rb
bundle exec arduino_ci.rb --skip-examples-compilation
status = $?
status = eval "bundle exec arduino_ci.rb --skip-examples-compilation"
echo "Status = $status"
if [ $status -ne 1 ]; then
exit 1
Expand Down
4 changes: 2 additions & 2 deletions SampleProjects/SharedLibrary/src/SharedLibrary.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#include "SharedLibrary.h"

void main() {
return foo; // unrecognized variable
int main() {
return foo; // 'foo' was not declared in this scope
}
4 changes: 1 addition & 3 deletions exe/arduino_ci.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,9 +438,7 @@ def perform_unit_tests(cpp_library, file_config)
end
next got_shared_library
end
if !got_shared_library
next
end
next unless got_shared_library
# now build and run each test using the shared library build above
config.allowable_unittest_files(cpp_library.test_files).each do |unittest_path|
unittest_name = unittest_path.basename.to_s
Expand Down