Skip to content

Switch Windows tests back to Windows #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 15, 2021
Merged

Switch Windows tests back to Windows #314

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
efde4b7
Switch Windows tests back to Windows.
jgfoster Oct 10, 2021
567ada3
Try tests with `text=LF` to satisfy linter that doesn't want any CR l…
jgfoster Oct 13, 2021
66fc3be
Change `uint` to `uint16_t` to be more explicit and (we hope) satisfy…
jgfoster Oct 13, 2021
88db503
Fix syntax for `text eol=lf` settings.
jgfoster Oct 13, 2021
7fe8f55
Was the change really needed? It looks like rubocop is complaining ab…
jgfoster Oct 13, 2021
7dc30a2
Change the specific configuration again to revert to original.
jgfoster Oct 13, 2021
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Was the change really needed? It looks like rubocop is complaining ab… 
…out CR but the test doesn't fail!?
  • Loading branch information
@jgfoster
jgfoster committed Oct 13, 2021
commit 7fe8f550c62e9e8917913b7948fd76cb1bf1cb9e
6 changes: 2 additions & 4 deletions .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,8 @@
# in your working directory. In either case, they will have LF line endings in
# the Git repository itself.

# We would pick auto (so Windows users have CRLF to satisfy dumb editors),
# but the automated tests include some sort of linting that complains when
# a CR is detected. So, we use LF to force it to LF on all platforms!
* text eol=lf
# Set the default behavior, in case people don't have core.autocrlf set.
* text eol=auto

# Explicitly declare text files you want to always be normalized and converted
# to native line endings on checkout. Git would likely get these right, but
Expand Down