Fix problem with warnings for platforms #297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jgfoster added a commit to jgfoster/TankController that referenced this pull request Apr 4, 2021
| Is the YAML file a necessary part of the fix? If not, I'll just fix the typo in my branch |
| The YAML file is a test of the fix. If you add the YAML file without the |
| Understood. I'm going to exercise this with unit testing instead, as I should have done earlier to prevent such an obvious error. |
Closed
| Unit tests are here aacfdb2 |
jgfoster pushed a commit to jgfoster/arduino_ci that referenced this pull request Sep 2, 2021
prestoncarman pushed a commit to Open-Acidification/TankController that referenced this pull request Sep 2, 2021
* Suppress warnings in external libraries. * Depends on Arduino-CI/arduino_ci#297. * Push trivial change to see if failing test in PR causes badge to update. Co-authored-by: James Foster <git@jgfoster.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
As a follow-up to #292, I tried to add warnings for a platform and found that it doesn't work. This should fix it.