Skip to content

Conversation

jgfoster
Copy link
Member

@jgfoster jgfoster commented Nov 5, 2020

This takes the edits from here and makes them a separate PR.

Fixes #133 (and #165), simplifies #189, and replaces part of #144.

James Foster added 2 commits November 4, 2020 22:56
@ianfixes
Copy link
Collaborator

ianfixes commented Nov 5, 2020

I see both a template and a macro definition of max. If both are needed, can you add some code comments explaining that?

@ianfixes
Copy link
Collaborator

ianfixes commented Nov 5, 2020

Oh, I see what's happening: #ifdef __cplusplus wraps the whole section. Can you indent the "body" of both the #ifdef and the #else sections of __cplusplus to make them more evident?

@matthijskooijman matthijskooijman mentioned this pull request Nov 5, 2020
@jgfoster
Copy link
Member Author

jgfoster commented Nov 5, 2020

Indent added (note that it would be undone by clang-format).

@ianfixes
Copy link
Collaborator

ianfixes commented Nov 7, 2020

I know the formatting isn't standard. There is a lot of c++-side stuff that I'd prefer to keep on the readability side, since this project is still working its way to feature-completeness. Once it works, I'm hoping the larger group of contributors that have joined in will be able to help me take a second look at how it all could be made more solid.

The end goal would be some direct tie-in with the Arduino project itself to enable these sorts of tests in a batteries-included sort of way in the IDE. But that's a long way off, if ever.

@ianfixes ianfixes merged commit f6ca7a7 into Arduino-CI:master Nov 7, 2020
@jgfoster jgfoster deleted the arvmath branch November 11, 2020 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants