Concurrent rendering naming fixes #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
In short, because components do not have a node in the model state tree managed by the layout, keys for elements in the components were being registered to the parent of the component rather than to a node for the component which contained the elements. The short-term solution was to make it so components wrap their contents in a div without a key. The long-term solution is to refactor the Layout() and give components a dedicated node in the model state tree
* docs for components sharing state * Add new line to end of file * Update docs/source/adding-interactivity/components-sharing-state/_examples/filterable_list/data.json * Update docs/source/adding-interactivity/components-sharing-state/_examples/filterable_list/data.json * Update docs/source/adding-interactivity/components-sharing-state/_examples/filterable_list/data.json * Update docs/source/adding-interactivity/components-sharing-state/_examples/filterable_list/data.json * Update docs/source/adding-interactivity/components-sharing-state/_examples/filterable_list/app.py * Update docs/source/adding-interactivity/components-sharing-state/_examples/filterable_list/app.py * Update docs/source/adding-interactivity/components-sharing-state/_examples/filterable_list/data.json * making syncedinputs an example, moving to managing-state * fixing isort import issue in shared-component-state examples * fixing link references * fixing docker build by upgrading npm and fast-json-path * Update noxfile.py Co-authored-by: Alessio Civitillo <@acivitillo@dyvenia.com> Co-authored-by: Ryan Morshead <ryan.morshead@gmail.com>
* implement use_context hook * refine docs and make space for docs on contexts
* minor improvements to project setup * install docs + fix ruff errors * fix lint * fixes first
* use env instead of env_dict * check mypy on tasks
* identify issue from reactive-python#1081 * fix the bug * update doc * make ruff happy * add changelog entry
Co-authored-by: Ryan Morshead <ryan.morshead@gmail.com>
* fix changelog * narrow pre-commit steps to particular files
- Change `reactpy.backends.utils.find_all_implementations()` to first try to import `<backend_name>` before importing `reactpy.backend.<backend_name>` - Allows for missing sub-dependencies to not cause `reactpy.run` to silently fail - Import `uvicorn` directly within `serve_with_uvicorn` in order to defer import. - Allows for `ModuleNotFound: Could not import uvicorn` exception to tell the user what went wrong - Added `CommonOptions.serve_index_route: bool` - Allows us to not clutter the route patterns when it's not needed - There are real circumstances where a user might want the index route to 404 - Fix bug where in-use ports are being assigned on Windows. - Removes `allow_reuse_waiting_ports` parameter on `find_available_port()` - Rename `BackendImplementation` to `BackendProtocol` - Change load order of `SUPPORTED_PACKAGES` so that `FastAPI` has a chance to run before `starlette` - Rename `SUPPORTED_PACKAGES` to `SUPPORTED_BACKENDS` - Refactor `reactpy.backend.*` code to be more human readable - Use f-strings where possible - Merge `if` statements where possible - Use `contextlib.supress` where possible - Remove defunct `requirements.txt` file
* need to copy scheme from base url * add changelog entry
* misc * fix lint
* Fix flask backend mimetype for modules * Update changelog --------- Co-authored-by: Ryan Morshead <ryan.morshead@gmail.com>
* initial work on concurrent renders * concurrent renders * limit to 3.11 * fix docs * update changelog * simpler add_effect interface * improve docstring * better changelog description * effect function accepts stop event * simplify concurrent render process * test serial renders too * remove ready event * fix doc example * add docstrings * use function scope async fixtures * fix flaky test * rename config option * move effect kick-off into component did render * move effect start to back to layout render * try 3.x again * require tracerite 1.1.1 * fix docs build
* fix docker nodejs install * use install script
* skip rendering none * add changelog * conditional render none should not reset state for sibling components * minor renaming + better changelog * misc fixes * raises exceptiongroup * skipif * handle egroup in starlette * final nocov
Bumps [postcss](https://github.com/postcss/postcss) from 8.4.24 to 8.4.35. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@8.4.24...8.4.35) --- updated-dependencies: - dependency-name: postcss dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 3.2.7 to 3.2.8. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v3.2.8/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v3.2.8/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mark Bakhit <archiethemonger@gmail.com>
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 3.2.7 to 3.2.8. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v3.2.8/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v3.2.8/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mark Bakhit <archiethemonger@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
The previous PR (reactive-python#1165) had some inconsistent naming. This PR works to fix that.
Checklist
Please update this checklist as you complete each item:
By submitting this pull request I agree that all contributions comply with this project's open source license(s).