Skip to content
This repository was archived by the owner on Sep 17, 2025. It is now read-only.
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tests fixes
  • Loading branch information
rashtao committed Mar 13, 2025
commit cf51f4833feddc22adb42952f60107e98f75a6f7
Original file line number Diff line number Diff line change
Expand Up @@ -592,6 +592,7 @@ public static Optional<String> extractLabel(final String id, final String label)
return Optional.ofNullable(label);
}

// FIXME: DE-996
public static String getId(Graph.Features.ElementFeatures features, String label, Object... keyValues) {
Optional<Object> optionalId = ElementHelper.getIdValue(keyValues);
if (!optionalId.isPresent()) {
Expand Down
8 changes: 4 additions & 4 deletions src/test/java/com/arangodb/tinkerpop/gremlin/TestGraph.java
Original file line number Diff line number Diff line change
Expand Up @@ -13,19 +13,19 @@
@Graph.OptOut(
test = "org.apache.tinkerpop.gremlin.structure.GraphTest",
method = "shouldAddVertexWithUserSuppliedStringId",
reason = "FIXME")
reason = "FIXME: DE-996")
@Graph.OptOut(
test = "org.apache.tinkerpop.gremlin.structure.GraphTest",
method = "shouldRemoveVertices",
reason = "Test creates vertices with random labels, which does not work with our schema-based approach.")
reason = "FIXME: DE-998")
@Graph.OptOut(
test = "org.apache.tinkerpop.gremlin.structure.GraphTest",
method = "shouldRemoveEdges",
reason = "Test creates edges with random labels, which does not work with our schema-based approach.")
reason = "FIXME: DE-998")
@Graph.OptOut(
test = "org.apache.tinkerpop.gremlin.structure.GraphTest",
method = "shouldEvaluateConnectivityPatterns",
reason = "FIXME")
reason = "FIXME: DE-996")
@Graph.OptOut(
test = "org.apache.tinkerpop.gremlin.structure.util.star.StarGraphTest",
method = "shouldAttachWithCreateMethod",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public Configuration newGraphConfiguration(String graphName, Class<?> test, Stri
conf.setProperty(Graph.GRAPH, TestGraph.class.getName());
return conf;
}

@Override
protected void configure(ArangoDBConfigurationBuilder builder, Class<?> test, String testMethodName) {
if (testMethodName.startsWith("shouldProcessVerticesEdges")
Expand Down Expand Up @@ -84,7 +84,7 @@ protected void configure(ArangoDBConfigurationBuilder builder, Class<?> test, St
break;
case "shouldEvaluateConnectivityPatterns":
builder.withEdgeCollection("knows");
builder.withEdgeCollection("knows");
builder.withEdgeCollection("hates");
break;
case "shouldRemoveEdgesWithoutConcurrentModificationException":
builder.withEdgeCollection("link");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,7 @@ public Map<String, Object> getBaseConfiguration(String graphName, Class<?> test,
return null;
}

// FIXME: DE-997
@Override
public Object convertId(Object id, Class<? extends Element> c) {
return id.toString();
Expand Down