fix: check for API key before attempting call #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
fubuloubu changed the title fubuloubu force-pushed the fix/client/check-api-key branch 3 times, most recently from 9fdb832 to e778e4c Compare 
antazoey previously approved these changes May 2, 2025
fubuloubu force-pushed the fix/client/check-api-key branch from 11c356f to 52923e2 Compare antazoey previously approved these changes Jul 29, 2025
fubuloubu force-pushed the fix/client/check-api-key branch from ac57d7b to bc1ca15 Compare antazoey approved these changes Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What I did
Noticed that when installed (as it is by default through
eth-ape[recommended-plugins]) but without an API key, that it will try (and fail) to fetch contract types through the new API, but fail because the API does not support un-authenticated requestsHow I did it
How to verify it
Checklist
- [ ] New test cases have been added and are passing- [ ] Documentation has been updated