Skip to content

PlaceholderWithoutTracking: removed default zero values for width and height props #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2020
Merged

PlaceholderWithoutTracking: removed default zero values for width and height props #58

merged 1 commit into from
Apr 4, 2020

Conversation

@strashkov
Copy link
Contributor

As sizes can be set in class attribute (props className), we should not set the default values to zero
Aljullu
Aljullu approved these changes Apr 4, 2020
View reviewed changes
Copy link
Owner

@Aljullu Aljullu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense. Thanks for working on this @strashkov.
@Aljullu Aljullu merged commit 2d52666 into Aljullu:master Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@strashkov @Aljullu