[MNT-25408]: ensure loader is not shown on nullish query #4885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rmnvch force-pushed the MNT-25408-loading-bar-state-fail branch from 38acb0f to d3a8318 Compare 
|
Contributor
| @rmnvch something is wrong. When I change filter set to "Dublin core" then files are filtered out but when I return to Default then I have still the same files like for Dublin core but earlier I had different for Default: Screen.Recording.2025-11-05.at.09.20.43.mov |
Contributor
| @rmnvch regarding to issue with "Reset" button - can we disable that button similarly like "Save Search" button when there is noting to reset? Screen.Recording.2025-11-05.at.09.28.33.mov |
| | ||
| expect(component.isLoading).toBeFalse(); | ||
| | ||
| updatedSubjectMock.next(null as SearchRequest); |
Contributor
There was a problem hiding this comment.
we don't use 'as' for nulls so please remove that as SearchRequest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
JIRA ticket link or changeset's description
https://hyland.atlassian.net/browse/MNT-25408?isEligibleForUserSurvey=true