Allow SASL_SSL without cert folder #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
follow upstream
…ned cert with SASL_SSL
hellmarbecker added a commit to hellmarbecker/python-fake-data-producer-for-apache-kafka that referenced this pull request Nov 20, 2022
Merge pull request Aiven-Labs#19 from hellmarbecker/main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
About this change - What it does
Allows running in SASL_SSL mode without specifyhing the cert folder
Sets the cacert path to None if no cert folder was given
Resolves: #xxxxx
Why this way
Makes it possible to work with services that don't use a self signed cert but use a public root CA - such as AWS MSK when using public endpoint and SCRAM-512 auth