Skip to content

fix: change WINDOW clause position #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2025
Merged

fix: change WINDOW clause position #173

merged 1 commit into from
Jul 11, 2025

Conversation

Blackmorse
Copy link
Contributor

WINDOW clause should come after HAVING clause
@coveralls
Copy link

Pull Request Test Coverage Report for Build 16203632494

Details

  • 6 of 8 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 63.93%
Changes Missing Coverage Covered Lines Changed/Added Lines %
parser/parser_query.go 5 7 71.43%
Totals Coverage Status
Change from base Build 16046293385: 0.4%
Covered Lines: 7591
Relevant Lines: 11874
💛 - Coveralls
git-hulk
git-hulk approved these changes Jul 11, 2025
View reviewed changes
Copy link
Member

@git-hulk git-hulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@git-hulk
Copy link
Member

@Blackmorse Many thanks to your fix.
@git-hulk git-hulk merged commit 91718f8 into AfterShip:master Jul 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@Blackmorse @coveralls @git-hulk