V628-024 Symbol diff has been added #998
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
AnthonyLeonardoGracio requested changes Jul 11, 2022
| Out_Span, | ||
| Edit); | ||
| | ||
| if Span.last.line - Span.first.line > 5 then |
There was a problem hiding this comment.
Need a comment explaining this threshold
There was a problem hiding this comment.
You have a space at the end of comment, I guess
| Span : LSP.Messages.Span; | ||
| New_Text : VSS.Strings.Virtual_String; | ||
| Edit : out LSP.Messages.TextEdit_Vector); | ||
| -- Create a diff between document Text inside Span and New_Chunk and |
There was a problem hiding this comment.
You don't explain the difference with the 'Diff' function here... You should explain why the TextEdits will be different (i.e: it will not replace the whole line a by a new line, but only add/delete some characters when possible).
AnthonyLeonardoGracio requested changes Jul 11, 2022
reznikmm reviewed Jul 12, 2022
ogorodnik force-pushed the V628-024 branch 2 times, most recently from ad3a3fd to 2810233 Compare 
| The CI does not pass, please check again |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.