U610-067 Pretty printer options #748
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Using the corresponding project that a file belongs to get the options.
AnthonyLeonardoGracio requested changes Jul 23, 2021
| Value => Options, | ||
| Is_Default_Value => Default); | ||
| | ||
| -- Initialize an gnatpp command line object |
There was a problem hiding this comment.
"Initialize the gnatpp command line"
| | ||
| -- Initialize an gnatpp command line object | ||
| Last := Options'First - 1; | ||
| for Item of Options.all loop |
There was a problem hiding this comment.
Lacking comments. Put a comment to say that we are counting valid options here for instance, people don't want to analyze each loop in your code
| end if; | ||
| end loop; | ||
| | ||
| Validated := new GNAT.Strings.String_List (Options'First .. Last); |
There was a problem hiding this comment.
"Validated_Options" would be even better
| -- A reference to the file reader created for this context | ||
| end record; | ||
| | ||
| procedure Get_PP_Options |
| URI : LSP.Types.LSP_String) return LSP.Types.LSP_String; | ||
| -- Turn URI into path | ||
| | ||
| function Get_Project |
There was a problem hiding this comment.
LSP.Ada_Documents seems a better package to put that function (might be reused somewhere else in the future)
| (Self : access Message_Handler; | ||
| Uri : LSP.Messages.DocumentUri) | ||
| return GNATCOLL.Projects.Project_Type; | ||
| -- Retrieve the project that the file belongs to. Root project is returned |
There was a problem hiding this comment.
You should say what it does for aggregate projects (that's the purpose of your function)
| closing till we get real issue with this |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Using the corresponding project that a file belongs to
get the options.