SA22-032 Code folding #351
Conversation
| return Libadalang.Analysis.Ada_Node; | ||
| -- Get Libadalang Root node for the given document. | ||
| | ||
| function Get_First_Token |
There was a problem hiding this comment.
I don't see where Get_First_Token is called. Do we really need it?
| return Libadalang.Analysis.Ada_Node; | ||
| -- Get Libadalang Node for given position in the document. | ||
| | ||
| function Get_Root_Node |
There was a problem hiding this comment.
May I suggest to not expose the root node, but move folding population code into the Ada_Documents instead? It would make Ada_Handler a bit shorter.
| end if; | ||
| | ||
| if Value.capabilities.textDocument.foldingRange.Is_Set then | ||
| if Value.capabilities.textDocument.foldingRange.Value. |
There was a problem hiding this comment.
Use and then instead of then if?
| (Is_Set => True, Value => LSP.Messages.Region); | ||
| | ||
| Sloc := Sloc_Range (Data (Node.Token_Start)); | ||
| foldingRange.startLine := LSP_Number (Sloc.Start_Line) - 1; |
There was a problem hiding this comment.
Could you reuse LSP.Lal_Utils.Get_Node_Location function? This will simplifies job when we will fix Position.column calculation at some point. The offsets are based on a UTF-16 string representation, so counting it as character index is incorrect.
| data => <>)); | ||
| return Response; | ||
| if Doc /= null then | ||
| -- Doc.Get_Root_Node (C.all).Unit.Print; |
| procedure Parse (Node : Libadalang.Analysis.Ada_Node); | ||
| -- Check the Node and all its children recursively | ||
| | ||
| procedure Parse (Token : Libadalang.Common.Token_Reference); |
There was a problem hiding this comment.
s/represen t/represent/ or may be contain is better.
| Store_With; | ||
| end case; | ||
| | ||
| declare |
There was a problem hiding this comment.
A proposal: use standard Libadalang traverse procedure to iterate tree nodes, then do a separate pass over trivias-comments instead of inventing a custom traverse code.
Feel free to ignore.
| Don't forget to update the README once we have the request fully implemented |
| This should probably remove the |
4 participants
No description provided.