SA22-030: Filter out 'end label' references #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
AnthonyLeonardoGracio force-pushed the topic/SA22-030 branch from 1433a61 to 6bcb55d Compare 
setton requested changes Dec 10, 2019
source/ada/lsp-ada_handlers.adb Outdated
| | ||
| function Is_End_Label (Node : Ada_Node) return Boolean | ||
| is | ||
| (not Node.Parent.Is_Null and then Node.Parent.Kind in Ada_End_Name); |
There was a problem hiding this comment.
I think the test needs to be improved a little bit for the case the first parent is a DottedName which is itself child of the EndName - for instance in end <package>.<subpackage>
There was a problem hiding this comment.
Ok, I'll check this
And add a test case to make sure that we filter out child package end labels too.
AnthonyLeonardoGracio force-pushed the topic/SA22-030 branch from 6bcb55d to ded053f Compare setton approved these changes Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.