T713-012: Completion for generic package parameter #1041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
AdrienBoulanger force-pushed the topic/T713-012.completion.generic_package branch from a64e9f2 to a4b4917 Compare AdrienBoulanger changed the title Fix PP offset and adapt tests. Add tests.
AdrienBoulanger force-pushed the topic/T713-012.completion.generic_package branch from a4b4917 to 7783e47 Compare | Column : out Langkit_Support.Slocs.Column_Number) | ||
| return Libadalang.Analysis.Ada_Node'Class; | ||
| -- Get the node needed to match Pretty_Print_Rule | ||
| -- Column represent the block indentation level |
Collaborator
There was a problem hiding this comment.
Offset might be a better name then
Contributor Author
There was a problem hiding this comment.
In this case Offset = Column - 1, so we are really manipulating Column and not Offset
Collaborator
There was a problem hiding this comment.
Then I suggest to rename the parameter to Offset and fill it with Column - 1, will be clearer in my case
AnthonyLeonardoGracio approved these changes Sep 2, 2022
AdrienBoulanger deleted the topic/T713-012.completion.generic_package branch Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Add a test.