An enhancement on about-us section #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
OmarShawky1 requested changes Jan 1, 2024
Collaborator
OmarShawky1 left a comment
OmarShawky1 left a comment There was a problem hiding this comment.
Requested enhancements
In short, all the following are because of the table inconsistencies as following:
- Revert back all style changes (E.g., in Table of contents, you switched the number list with bullet points). This can be done via
git reset --soft HEAD~1and in vscode or in vim, you unstash and revert back some edits. - Use the tables and images provided in the features branches. In the example, none of the mini logos (LinkedIn, GitHub, Webpage) is working.
These changes will not be more than copy pasting the table under contributors and filling them with the data which you already wrote. I don't think the table should be more than 3 columns.
yosifshaban6 force-pushed the feat-AboutUs branch 2 times, most recently from 1c75b58 to efdc12e Compare 
Collaborator
| @youssef1s Please rebase (merge 2 commits into a single commit) |
yosifshaban6 force-pushed the feat-AboutUs branch 2 times, most recently from 6bd0cd3 to 36e2e0e Compare 
OmarShawky1 approved these changes Jan 12, 2024
README.md Outdated
| | ||
| #### CS-Fundamentals | ||
| | ||
| <<<<<<< HEAD |
Collaborator
There was a problem hiding this comment.
Please, Remove this (It is done due to merge conflicts). Please submit only one commit. Either due git reset --hard HEAD~11 (11 is the number of commits that you have) or use git rebase -i HEAD~1.
README.md Outdated
| 6. [Mentors](#mentors) | ||
| 7. [Events](#events) | ||
| 4. [Channels & Categories Onboarding](#channels--categories-onboarding) | ||
| - [Welcome to Active Courses University](#welcome-to-active-courses-university) |
Collaborator
There was a problem hiding this comment.
Revert back the Table of Contents Style.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Close #4
README: An enhancement on about-us section