Skip to content

Conversation

@hulxv
Copy link

@hulxv hulxv commented Dec 17, 2023

Closes #4

@OmarShawky1
Copy link
Collaborator

Requested changes

  1. The order of "About Us" is: Board of Leaders, Mentors, Curriculum Maintainers, Contributors. Please maintain same order.
  2. Switch back all style changes. (Maybe do another PR with it if you want). you can save them locally using git stash if you are not familiar with git.
@hulxv hulxv force-pushed the add-about-us-section branch from addfa6a to eb24428 Compare December 18, 2023 22:51
@hulxv
Copy link
Author

hulxv commented Dec 18, 2023

Is there anything else should I do?

@OmarShawky1
Copy link
Collaborator

@hulxv
Excellent work. 2 things that can even make it more excellent.

  1. In table, use |:-:| to center text in table. you don't need to use more than -.
  2. Try to use logos from website instead of text.

If you don't want to do it, then this is fine and I will do it myself :)

@hulxv hulxv force-pushed the add-about-us-section branch from 00354bb to c06effd Compare December 19, 2023 13:48
@hulxv
Copy link
Author

hulxv commented Dec 19, 2023

@hulxv hulxv force-pushed the add-about-us-section branch from d5d09b1 to 9ba6e7f Compare December 19, 2023 14:06
@OmarShawky1
Copy link
Collaborator

Fixed in #4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants