Remove NodeGraph dependency in ShaderTranslation #2601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…plementation - as this is not required.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
While working on some side experiments - I bumped in to a case where the shader translation tests were failing because I did not have a nodegraph to implement the translation node.
I don't think this should be a requirement, and we only seem to be using the NodeGraph to find the outputs, which are also available on the NodeDef object.
This appears to pass all the tests, but I do have a question about the code here. The comment suggests perhaps a NodeGraph is a requirement - but I haven't seen this documented anywhere, and I'm not familiar enough with the context the comment is referring to to understand what it means. If there is some requirement in the system like this, it would be great to have a unit tests that validates it, so we ensure we don't regress.