Potential fix for code scanning alert no. 186: Call to System.IO.Path.Combine #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
….Combine Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/ATrefzer/CSharpCodeAnalyst/security/code-scanning/186
To fix the flagged issue, replace the usage of
Path.Combine(referenceFolder, outputFileName)withPath.Join(referenceFolder, outputFileName)at line 132 in ApprovalTestTool/Program.cs. This change avoids the risk of the first argument being dropped if the second argument is an absolute path;Path.Joinwill always join both, even if the second is absolute.Only the single line needs changing. No additional imports or modifications are necessary, as both
Path.CombineandPath.Joinare members ofSystem.IO.Path.Suggested fixes powered by Copilot Autofix. Review carefully before merging.