Skip to content

Conversation

add psa_lifecycle description add psa_platform description add TF-M porting guide extend porting guide with targets and labels description
Copy link
Contributor

@AnotherButler AnotherButler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add initial queries and comments before editing.

@@ -1 +1,3 @@
tags
.DS_Store
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Query: What is this file for? Should it be here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these files are annoying artefacts created by MacOS filesystem - https://en.wikipedia.org/wiki/.DS_Store

@@ -0,0 +1,3 @@
#!/usr/bin/env bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Query: What is this file for? Should it be here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

used this script to generate the nice PNG state machine graph.
please suggest the best place for it.

@@ -0,0 +1,11 @@
digraph {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Query: What is this file for? Should it be here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

used this file in DOT language for describing the lifecycle state machine.
please suggest the best place for it.


In mbed-os PSA Lifecycle is implemented as part of [platform service](../platform_servcie.md)

TODO: link to doxygen No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an example, in addition to the Doxygen.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, what are the use cases for this API?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what kind of example required here?

Platform service introduces system reset and PSA Lifecycle APIs.
PSA platform service may be extended by target vendors to expose target peripherals only accessible from secure side.

Todo: link to doxygen No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Query: What are the use cases for this API?

Also, please add an example, in addition to the Doxygen.


- PSA [RoT](../introduction/glossary.html) internal storage.
- [PSA Crypto APIs (on GitHub)](https://github.com/ARMmbed/mbed-crypto/tree/development/docs).
- PSA Attestation - TBD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like including "TBD" in our docs. Does anyone oppose removing this line until we have an Attestation link?


<span class="notes">This page gives guidelines for silicon partners adding SPM capabilities.</span>

mbed-os
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a placeholder for anything, or can we remove this line?



#### JSON target definition

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


### TF-M SPM porting for (ARMv8-M targets)

TF-M HAL functions are defined in `tfm_spm_hal.h`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's link to this once the Doxygen merges. Also, is there more to add to this section? It feels sparse.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not sure why it is not generated

@alzix
Copy link
Contributor

alzix commented Mar 2, 2019

sorry i opened this PR using our team account - closing and will reopen with my account

@alzix alzix closed this Mar 2, 2019
@alzix alzix mentioned this pull request Mar 2, 2019
Copy link
Contributor

@GuyWi GuyWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my review in PSA core 5.12 #986.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants